package server import ( "bytes" "encoding/json" "fmt" "io" "log/slog" "mime" "mime/multipart" "net/http" "net/http/httptest" "net/url" "os" "path/filepath" "regexp" "slices" "strings" "testing" "testing/fstest" "time" "uncensored-send/internal/auth" "uncensored-send/internal/config" "uncensored-send/internal/store" ) // clock is the fixed instant tests start from; s.now is swapped so expiry can // be exercised without sleeping. var clock = time.Date(2026, 9, 12, 10, 0, 0, 0, time.UTC) type harness struct { *Server ts *httptest.Server dir string now time.Time token string // a token allowing vanity names admin string } func newHarness(t *testing.T, tweak func(*config.Config)) *harness { t.Helper() dir := t.TempDir() cfg := config.Config{} fs := config.NewSet("test", "UNCENSORED_SEND_TEST_") cfg.Register(fs) if err := fs.Parse(nil); err != nil { t.Fatal(err) } cfg.DataDir = dir cfg.MaxSize = 1 << 20 cfg.MaxExpiry = 72 * time.Hour cfg.DefaultExpiry = 72 * time.Hour cfg.MinFreeBytes = 0 cfg.UploadRate = 100000 cfg.UploadBurst = 100000 if tweak != nil { tweak(&cfg) } if err := cfg.Normalise(); err != nil { t.Fatal(err) } st, err := store.Open(cfg.DataDir) if err != nil { t.Fatal(err) } tokens, err := auth.Load(cfg.TokensPath) if err != nil { t.Fatal(err) } h := &harness{dir: dir, now: clock} for _, spec := range []struct { name string admin bool dst *string }{{"friend", false, &h.token}, {"boss", true, &h.admin}} { secret, err := store.NewSecret() if err != nil { t.Fatal(err) } if err := tokens.Add(&auth.Token{ Name: spec.name, Hash: auth.HashSecret(secret), AllowVanity: true, Admin: spec.admin, }); err != nil { t.Fatal(err) } *spec.dst = secret } log := slog.New(slog.NewTextHandler(io.Discard, nil)) srv, err := New(&cfg, st, tokens, log) if err != nil { t.Fatal(err) } srv.now = func() time.Time { return h.now } h.Server = srv h.ts = httptest.NewServer(srv) t.Cleanup(h.ts.Close) return h } // upload posts a raw body, the way curl does. func (h *harness) upload(t *testing.T, body []byte, headers map[string]string) *http.Response { t.Helper() return h.uploadReader(t, bytes.NewReader(body), headers) } func (h *harness) uploadReader(t *testing.T, body io.Reader, headers map[string]string) *http.Response { t.Helper() req, err := http.NewRequest("POST", h.ts.URL+"/upload", body) if err != nil { t.Fatal(err) } req.Header.Set("Accept", "application/json") for k, v := range headers { req.Header.Set(k, v) } resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } return resp } // session builds the cookie a browser would be holding for this token. The // value is sealed, so a test cannot simply write the token into it. func (h *harness) session(t *testing.T, token string) *http.Cookie { t.Helper() sealed, err := h.sessions.seal(token) if err != nil { t.Fatal(err) } return &http.Cookie{Name: tokenCookie, Value: sealed} } func decode[T any](t *testing.T, resp *http.Response) T { t.Helper() defer resp.Body.Close() var v T if err := json.NewDecoder(resp.Body).Decode(&v); err != nil { t.Fatalf("decoding %s response: %v", resp.Status, err) } return v } func TestRoundTrip(t *testing.T) { h := newHarness(t, nil) payload := bytes.Repeat([]byte("godot"), 4096) resp := h.upload(t, payload, map[string]string{ "Content-Disposition": `attachment; filename="MyGame.zip"`, }) if resp.StatusCode != http.StatusCreated { t.Fatalf("upload status = %s", resp.Status) } res := decode[uploadResult](t, resp) if res.Filename != "MyGame.zip" { t.Errorf("filename = %q, want MyGame.zip", res.Filename) } if res.Size != int64(len(payload)) { t.Errorf("size = %d, want %d", res.Size, len(payload)) } if res.DeleteToken == "" { t.Error("no delete token returned") } get, err := h.ts.Client().Get(h.ts.URL + "/d/" + res.ID) if err != nil { t.Fatal(err) } defer get.Body.Close() got, _ := io.ReadAll(get.Body) if !bytes.Equal(got, payload) { t.Errorf("downloaded %d bytes, want %d", len(got), len(payload)) } // An uploaded file must never come back as something a browser will run. if ct := get.Header.Get("Content-Type"); ct != "application/octet-stream" { t.Errorf("Content-Type = %q", ct) } if get.Header.Get("X-Content-Type-Options") != "nosniff" { t.Error("missing nosniff") } if !strings.Contains(get.Header.Get("Content-Security-Policy"), "sandbox") { t.Errorf("CSP = %q", get.Header.Get("Content-Security-Policy")) } disp, params, err := mime.ParseMediaType(get.Header.Get("Content-Disposition")) if err != nil || disp != "attachment" || params["filename"] != "MyGame.zip" { t.Errorf("Content-Disposition = %q (%v)", get.Header.Get("Content-Disposition"), err) } } func TestHTMLUploadIsServedInert(t *testing.T) { h := newHarness(t, nil) resp := h.upload(t, []byte(""), map[string]string{ "Content-Disposition": `attachment; filename="evil.html"`, }) res := decode[uploadResult](t, resp) get, err := h.ts.Client().Get(h.ts.URL + "/d/" + res.ID) if err != nil { t.Fatal(err) } defer get.Body.Close() if ct := get.Header.Get("Content-Type"); ct != "application/octet-stream" { t.Errorf("HTML served as %q; it must never be text/html", ct) } if !strings.HasPrefix(get.Header.Get("Content-Disposition"), "attachment") { t.Error("HTML was not served as an attachment") } } func TestRangeRequest(t *testing.T) { h := newHarness(t, nil) payload := bytes.Repeat([]byte("abcdefgh"), 1024) res := decode[uploadResult](t, h.upload(t, payload, nil)) req, _ := http.NewRequest("GET", h.ts.URL+"/d/"+res.ID, nil) req.Header.Set("Range", "bytes=0-1023") get, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } defer get.Body.Close() if get.StatusCode != http.StatusPartialContent { t.Fatalf("status = %s, want 206", get.Status) } body, _ := io.ReadAll(get.Body) if len(body) != 1024 || !bytes.Equal(body, payload[:1024]) { t.Errorf("got %d bytes, want the first 1024", len(body)) } if cr := get.Header.Get("Content-Range"); cr != fmt.Sprintf("bytes 0-1023/%d", len(payload)) { t.Errorf("Content-Range = %q", cr) } } // An oversized body must be refused on bytes actually written, never on a // declared length. This sends a chunked body, so there is no Content-Length to // consult even if the code wanted to. func TestOversizeChunkedUploadIsRefused(t *testing.T) { h := newHarness(t, func(c *config.Config) { c.MaxSize = 4096 }) // A plain io.Reader (not a *bytes.Buffer) makes the client use chunked // encoding with no declared length. body := io.LimitReader(zeroes{}, 1<<20) resp := h.uploadReader(t, struct{ io.Reader }{body}, nil) defer resp.Body.Close() if resp.StatusCode != http.StatusRequestEntityTooLarge { t.Fatalf("status = %s, want 413", resp.Status) } if n := h.store.Count(); n != 0 { t.Errorf("%d objects stored after a refused upload", n) } assertNoDebris(t, h.dir) } // A body one byte over the cap is refused; exactly at the cap is accepted. func TestSizeLimitBoundary(t *testing.T) { h := newHarness(t, func(c *config.Config) { c.MaxSize = 1000 }) resp := h.upload(t, bytes.Repeat([]byte("x"), 1000), nil) if resp.StatusCode != http.StatusCreated { t.Fatalf("exactly at the limit: status = %s, want 201", resp.Status) } resp.Body.Close() resp = h.upload(t, bytes.Repeat([]byte("x"), 1001), nil) defer resp.Body.Close() if resp.StatusCode != http.StatusRequestEntityTooLarge { t.Fatalf("one byte over: status = %s, want 413", resp.Status) } } type zeroes struct{} func (zeroes) Read(p []byte) (int, error) { return len(p), nil } func TestAnonymousCannotClaimVanity(t *testing.T) { h := newHarness(t, nil) resp := h.upload(t, []byte("hi"), map[string]string{"Vanity": "my-file"}) defer resp.Body.Close() if resp.StatusCode != http.StatusForbidden { t.Fatalf("status = %s, want 403", resp.Status) } if h.store.Exists("my-file") { t.Error("the name was claimed despite the refusal") } } func TestVanityCollision(t *testing.T) { h := newHarness(t, nil) hdr := map[string]string{ "Vanity": "my-file", "Authorization": "Bearer " + h.token, } resp := h.upload(t, []byte("first"), hdr) if resp.StatusCode != http.StatusCreated { t.Fatalf("first upload: status = %s", resp.Status) } resp.Body.Close() resp = h.upload(t, []byte("second"), hdr) defer resp.Body.Close() if resp.StatusCode != http.StatusConflict { t.Fatalf("second upload: status = %s, want 409", resp.Status) } // The first object must be untouched. get, err := h.ts.Client().Get(h.ts.URL + "/d/my-file") if err != nil { t.Fatal(err) } defer get.Body.Close() body, _ := io.ReadAll(get.Body) if string(body) != "first" { t.Errorf("content = %q, want %q", body, "first") } } func TestUnknownTokenIsRejected(t *testing.T) { h := newHarness(t, nil) resp := h.upload(t, []byte("hi"), map[string]string{"Authorization": "Bearer nope"}) defer resp.Body.Close() if resp.StatusCode != http.StatusUnauthorized { t.Fatalf("status = %s, want 401", resp.Status) } } // Expiry is enforced on read, not only by the sweeper, which never runs here. func TestExpiryIsCheckedOnRead(t *testing.T) { h := newHarness(t, nil) res := decode[uploadResult](t, h.upload(t, []byte("ephemeral"), map[string]string{ "Expiry": "1h", })) status := func(when time.Duration) int { h.now = clock.Add(when) get, err := h.ts.Client().Get(h.ts.URL + "/d/" + res.ID) if err != nil { t.Fatal(err) } get.Body.Close() return get.StatusCode } if got := status(59 * time.Minute); got != http.StatusOK { t.Fatalf("before expiry: status = %d, want 200", got) } if got := status(61 * time.Minute); got != http.StatusNotFound { t.Fatalf("after expiry: status = %d, want 404", got) } // The read path also reclaims the space. if _, err := os.Stat(filepath.Join(h.dir, "objects", res.ID)); !os.IsNotExist(err) { t.Error("expired object was not removed on read") } } func TestExpiryBeyondLimitIsRefused(t *testing.T) { h := newHarness(t, nil) // max 72h for anonymous for _, req := range []string{"30d", "never"} { resp := h.upload(t, []byte("hi"), map[string]string{"Expiry": req}) if resp.StatusCode != http.StatusBadRequest { t.Errorf("Expiry: %s => status %s, want 400", req, resp.Status) } resp.Body.Close() } } func TestTokenMayOutliveTheAnonymousLimit(t *testing.T) { h := newHarness(t, nil) forever := "never" if err := h.tokens.Remove("friend"); err != nil { t.Fatal(err) } secret, _ := store.NewSecret() if err := h.tokens.Add(&auth.Token{ Name: "friend", Hash: auth.HashSecret(secret), MaxExpiry: &forever, DefaultExpiry: &forever, AllowVanity: true, }); err != nil { t.Fatal(err) } res := decode[uploadResult](t, h.upload(t, []byte("keep me"), map[string]string{ "Authorization": "Bearer " + secret, "Expiry": "never", })) if res.Expires != "" { t.Errorf("expires = %q, want empty (never)", res.Expires) } } func TestPathTraversalIsRejected(t *testing.T) { h := newHarness(t, nil) // As a requested vanity name. for _, name := range []string{"../etc/passwd", "..", ".", "/absolute", "a/b", `a\b`, "ok..name"} { resp := h.upload(t, []byte("x"), map[string]string{ "Vanity": name, "Authorization": "Bearer " + h.token, }) if resp.StatusCode == http.StatusCreated { t.Errorf("vanity %q was accepted", name) } resp.Body.Close() } // As a download path. Some of these are normalised away into a redirect to // the index, which is harmless; what matters is that no stored bytes are // ever served, so the check is for an object response rather than a status. for _, path := range []string{ "/d/..%2f..%2fetc%2fpasswd", "/d/.", "/d/..", "/d/%2e%2e", "/d/../tokens.json", "/d/%2e%2e%2ftokens.json", "/d/objects", } { get, err := h.ts.Client().Get(h.ts.URL + path) if err != nil { continue // the client itself may refuse to send it, which is fine } get.Body.Close() if get.Header.Get("Content-Disposition") != "" { t.Errorf("GET %s served an object", path) } } } // A vanity name has only the spelling rules to satisfy. Names that look like // routes or like the site's own assets are ordinary names, because an id is // reachable only under /d/ and /i/ and never collides with anything of ours. func TestVanityNamesThatLookLikeRoutesAreOrdinary(t *testing.T) { h := newHarness(t, nil) for _, name := range []string{"favicon.png", "admin", "login", "upload", "static", "robots.txt", "tokens.json"} { resp := h.formUpload(t, map[string]string{"vanity": name, "token": h.token}, "f.txt", "body of "+name) body, _ := io.ReadAll(resp.Body) resp.Body.Close() if resp.StatusCode != http.StatusCreated { t.Errorf("vanity %q => %s: %s", name, resp.Status, strings.TrimSpace(string(body))) continue } // And it is genuinely reachable at the name that was asked for. got := h.get(t, "/d/"+name, "") content, _ := io.ReadAll(got.Body) got.Body.Close() if got.StatusCode != http.StatusOK { t.Errorf("GET /d/%s => %s, want 200", name, got.Status) } if string(content) != "body of "+name { t.Errorf("GET /d/%s served %q, not the file that was uploaded", name, content) } } } // The spelling rules themselves still stand: they are what keeps a name from // becoming a path element it should not be. func TestMalformedVanityNamesAreRefused(t *testing.T) { h := newHarness(t, nil) for _, name := range []string{"d", "i", "no spaces allowed", "-leading-dash", "..", "trailing.", "a/b"} { resp := h.upload(t, []byte("x"), map[string]string{ "Vanity": name, "Authorization": "Bearer " + h.token, }) resp.Body.Close() if resp.StatusCode != http.StatusBadRequest { t.Errorf("vanity %q => %s, want 400", name, resp.Status) } } } func TestDeleteRequiresTheRightToken(t *testing.T) { h := newHarness(t, nil) res := decode[uploadResult](t, h.upload(t, []byte("delete me"), nil)) del := func(token string) int { form := strings.NewReader("token=" + token) req, _ := http.NewRequest("POST", h.ts.URL+"/d/"+res.ID+"/delete", form) req.Header.Set("Content-Type", "application/x-www-form-urlencoded") req.Header.Set("Accept", "application/json") resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } resp.Body.Close() return resp.StatusCode } if got := del("wrong-token"); got != http.StatusForbidden { t.Errorf("wrong token => %d, want 403", got) } if got := del(h.token); got != http.StatusForbidden { t.Errorf("a non-owning, non-admin token => %d, want 403", got) } if got := del(res.DeleteToken); got != http.StatusOK { t.Errorf("correct token => %d, want 200", got) } // The token is single-use because the object it names is gone. if got := del(res.DeleteToken); got != http.StatusNotFound { t.Errorf("reused token => %d, want 404", got) } assertNoDebris(t, h.dir) } func TestAdminMayDeleteAnything(t *testing.T) { h := newHarness(t, nil) res := decode[uploadResult](t, h.upload(t, []byte("someone else's"), nil)) req, _ := http.NewRequest("POST", h.ts.URL+"/d/"+res.ID+"/delete", nil) req.Header.Set("Authorization", "Bearer "+h.admin) req.Header.Set("Accept", "application/json") resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } resp.Body.Close() if resp.StatusCode != http.StatusOK { t.Fatalf("admin delete => %s, want 200", resp.Status) } } func TestMultipartUpload(t *testing.T) { h := newHarness(t, nil) var body bytes.Buffer mw := multipart.NewWriter(&body) // Order matters: the server needs these before the file part arrives. mw.WriteField("token", h.token) mw.WriteField("expiry", "2h") mw.WriteField("vanity", "from-the-form") fw, err := mw.CreateFormFile("file", "notes (draft).txt") if err != nil { t.Fatal(err) } fw.Write([]byte("hello from a browser")) mw.Close() req, _ := http.NewRequest("POST", h.ts.URL+"/upload", &body) req.Header.Set("Content-Type", mw.FormDataContentType()) req.Header.Set("Accept", "application/json") resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } if resp.StatusCode != http.StatusCreated { t.Fatalf("status = %s", resp.Status) } res := decode[uploadResult](t, resp) if res.ID != "from-the-form" { t.Errorf("id = %q, want from-the-form", res.ID) } if res.Filename != "notes (draft).txt" { t.Errorf("filename = %q", res.Filename) } } // A form post with no Accept: application/json gets the HTML success page, so // the no-JS path works. func TestFormPostRendersHTML(t *testing.T) { h := newHarness(t, nil) var body bytes.Buffer mw := multipart.NewWriter(&body) fw, _ := mw.CreateFormFile("file", "thing.bin") fw.Write([]byte("data")) mw.Close() req, _ := http.NewRequest("POST", h.ts.URL+"/upload", &body) req.Header.Set("Content-Type", mw.FormDataContentType()) req.Header.Set("Accept", "text/html,application/xhtml+xml") resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } defer resp.Body.Close() if ct := resp.Header.Get("Content-Type"); !strings.HasPrefix(ct, "text/html") { t.Fatalf("Content-Type = %q, want HTML", ct) } page, _ := io.ReadAll(resp.Body) if !strings.Contains(string(page), "Delete token") { t.Error("the success page does not show the delete token") } // The script asks for this same page and writes it into the document it is // running in, so a fragment would leave the browser with a half a page. if !strings.HasPrefix(string(page), "") || !strings.Contains(string(page), "") { t.Error("the success page is not a whole document") } if !strings.Contains(string(page), "static/app.js") { t.Error("the success page does not load the script, so its copy buttons stay dead") } } func TestBasePathMounting(t *testing.T) { h := newHarness(t, func(c *config.Config) { c.BasePath = "/send" }) get, err := h.ts.Client().Get(h.ts.URL + "/send/") if err != nil { t.Fatal(err) } defer get.Body.Close() if get.StatusCode != http.StatusOK { t.Fatalf("GET /send/ => %s", get.Status) } page, _ := io.ReadAll(get.Body) if !strings.Contains(string(page), `href="/send/static/style.css"`) { t.Error("page links do not carry the base path") } // The bare prefix redirects to the slashed form. noRedirect := *h.ts.Client() noRedirect.CheckRedirect = func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse } resp, err := noRedirect.Get(h.ts.URL + "/send") if err != nil { t.Fatal(err) } resp.Body.Close() if resp.StatusCode != http.StatusMovedPermanently { t.Errorf("GET /send => %s, want 301", resp.Status) } } // An upload that dies mid-flight must leave nothing visible behind, and the // sweeper must eventually reclaim the directory. func TestAbandonedUploadIsInvisibleAndSwept(t *testing.T) { h := newHarness(t, nil) up, err := h.store.Reserve("half-done") if err != nil { t.Fatal(err) } up.Write([]byte("partial")) // Deliberately no Commit and no Abort: this is what a killed process leaves. get, err := h.ts.Client().Get(h.ts.URL + "/d/half-done") if err != nil { t.Fatal(err) } get.Body.Close() if get.StatusCode != http.StatusNotFound { t.Errorf("an uncommitted object was visible: %s", get.Status) } dir := filepath.Join(h.dir, "objects", "half-done") old := clock.Add(-48 * time.Hour) if err := os.Chtimes(dir, old, old); err != nil { t.Fatal(err) } h.store.Sweep(clock) if _, err := os.Stat(dir); !os.IsNotExist(err) { t.Error("abandoned upload directory was not swept") } } func TestQuotaRefusesUploads(t *testing.T) { h := newHarness(t, func(c *config.Config) { c.MaxTotalBytes = 100 }) resp := h.upload(t, bytes.Repeat([]byte("x"), 80), nil) if resp.StatusCode != http.StatusCreated { t.Fatalf("first upload => %s", resp.Status) } resp.Body.Close() // Only 20 bytes of quota remain, so this is truncated to the remainder and // refused rather than allowed to overshoot. resp = h.upload(t, bytes.Repeat([]byte("x"), 80), nil) defer resp.Body.Close() if resp.StatusCode != http.StatusRequestEntityTooLarge { t.Fatalf("over quota => %s, want 413", resp.Status) } } func TestRateLimit(t *testing.T) { h := newHarness(t, func(c *config.Config) { c.UploadRate = 1 c.UploadBurst = 2 }) var last *http.Response for range 3 { if last != nil { last.Body.Close() } last = h.upload(t, []byte("x"), nil) } defer last.Body.Close() if last.StatusCode != http.StatusTooManyRequests { t.Fatalf("third upload => %s, want 429", last.Status) } } // assertNoDebris checks that no object directory was left behind. func assertNoDebris(t *testing.T, dir string) { t.Helper() entries, err := os.ReadDir(filepath.Join(dir, "objects")) if err != nil { t.Fatal(err) } for _, e := range entries { t.Errorf("leftover object directory: %s", e.Name()) } } // --- remembered tokens --------------------------------------------------- // Logging in is what stores a token; uploading never touches the cookie. func TestLoginStoresTheToken(t *testing.T) { h := newHarness(t, nil) resp := h.postForm(t, "/login", url.Values{"token": {h.token}, "persist": {"1"}}, nil) resp.Body.Close() if resp.StatusCode != http.StatusSeeOther { t.Fatalf("status = %s, want 303", resp.Status) } if loc := resp.Header.Get("Location"); loc != "/" { t.Errorf("Location = %q, want /", loc) } cookie := findCookie(resp, tokenCookie) if cookie == nil { t.Fatal("logging in set no cookie") } // The whole point of sealing it: the credential is not sitting in the // browser's cookie jar for anyone glancing at a developer console. if strings.Contains(cookie.Value, h.token) { t.Error("the cookie carries the token in the clear") } if got := h.sessions.open(cookie.Value); got != h.token { t.Errorf("the cookie does not open to the token (got %q)", got) } if !cookie.HttpOnly { t.Error("the session cookie is readable by scripts") } if cookie.SameSite != http.SameSiteStrictMode { t.Error("the session cookie is not SameSite=Strict, so it is CSRF-exposed") } if cookie.MaxAge <= 0 { t.Error("'stay logged in' did not persist the cookie") } // The session alone is now enough to claim a vanity name. req, _ := http.NewRequest("POST", h.ts.URL+"/upload", strings.NewReader("two")) req.Header.Set("Accept", "application/json") req.Header.Set("Vanity", "session-upload") req.AddCookie(cookie) up, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } if up.StatusCode != http.StatusCreated { t.Fatalf("upload with only the session: status = %s", up.Status) } if res := decode[uploadResult](t, up); res.ID != "session-upload" { t.Errorf("id = %q, want session-upload", res.ID) } } // Without "stay logged in" the cookie must die with the browser. func TestLoginWithoutPersistIsASessionCookie(t *testing.T) { h := newHarness(t, nil) resp := h.postForm(t, "/login", url.Values{"token": {h.token}}, nil) resp.Body.Close() c := findCookie(resp, tokenCookie) if c == nil { t.Fatal("no cookie was set") } if c.MaxAge != 0 || !c.Expires.IsZero() { t.Errorf("cookie carries a lifetime (MaxAge=%d), want a session cookie", c.MaxAge) } } func TestLoginRejectsAnUnknownToken(t *testing.T) { h := newHarness(t, nil) resp := h.postForm(t, "/login", url.Values{"token": {"not-a-token"}}, nil) raw, _ := io.ReadAll(resp.Body) resp.Body.Close() if resp.StatusCode != http.StatusUnauthorized { t.Fatalf("status = %s, want 401", resp.Status) } if findCookie(resp, tokenCookie) != nil { t.Error("a rejected login still set a cookie") } if !strings.Contains(string(raw), "not recognised") { t.Error("the login page does not say what went wrong") } } // Guessing a token at the login form is throttled; a correct one is not. func TestFailedLoginsAreThrottled(t *testing.T) { h := newHarness(t, nil) h.authLimiter = newLimiter(1, 3) var last *http.Response for range 5 { if last != nil { last.Body.Close() } last = h.postForm(t, "/login", url.Values{"token": {"guess"}}, nil) } if last.StatusCode != http.StatusTooManyRequests { t.Fatalf("repeated guesses => %s, want 429", last.Status) } last.Body.Close() resp := h.postForm(t, "/login", url.Values{"token": {h.token}}, nil) resp.Body.Close() if resp.StatusCode != http.StatusSeeOther { t.Fatalf("a correct token was throttled: %s", resp.Status) } } // The post-login destination is an allowlisted page name, never a URL, so it // cannot be turned into an open redirect. func TestLoginRedirectIsAllowlisted(t *testing.T) { h := newHarness(t, nil) for _, c := range []struct{ next, want string }{ {"files", "/files"}, {"", "/"}, {"https://evil.example.com", "/"}, {"//evil.example.com", "/"}, {"../../etc", "/"}, } { resp := h.postForm(t, "/login", url.Values{"token": {h.admin}, "next": {c.next}}, nil) resp.Body.Close() if loc := resp.Header.Get("Location"); loc != c.want { t.Errorf("next=%q => Location %q, want %q", c.next, loc, c.want) } } } func TestLogoutEndsTheSession(t *testing.T) { h := newHarness(t, nil) resp := h.postForm(t, "/logout", url.Values{}, h.session(t, h.token)) resp.Body.Close() if resp.StatusCode != http.StatusSeeOther { t.Fatalf("status = %s, want 303", resp.Status) } c := findCookie(resp, tokenCookie) if c == nil || c.MaxAge >= 0 || c.Value != "" { t.Fatalf("the session cookie was not cleared: %v", c) } } // Uploading must never change the session, in either direction. func TestUploadNeverTouchesTheSession(t *testing.T) { h := newHarness(t, nil) resp := h.formUpload(t, map[string]string{"token": h.token}, "a.bin", "one") resp.Body.Close() if c := findCookie(resp, tokenCookie); c != nil { t.Errorf("an upload with a one-off token set a session cookie: %v", c) } resp = h.formUploadWith(t, h.session(t, h.token), map[string]string{}, "b.bin", "two") resp.Body.Close() if c := findCookie(resp, tokenCookie); c != nil { t.Errorf("an upload cleared the session: %v", c) } } // A one-off token on the form wins over the logged-in session. func TestExplicitTokenBeatsTheCookie(t *testing.T) { h := newHarness(t, nil) cookie := h.session(t, h.token) resp := h.formUploadWith(t, cookie, map[string]string{"token": h.admin}, "b.bin", "y") defer resp.Body.Close() res := decode[uploadResult](t, resp) m, err := h.store.Get(res.ID, h.now) if err != nil { t.Fatal(err) } if m.Owner != "boss" { t.Errorf("owner = %q, want boss: the session shadowed the one-off token", m.Owner) } } // The cookie is sealed with a key this server holds, so one from anywhere else // is not a session. This is also the upgrade path: every cookie written in the // old plain-text format arrives here. func TestCookieFromAnotherKeyIsNotASession(t *testing.T) { h := newHarness(t, nil) // A cookie holding the raw token, exactly as the previous format wrote it. plain := &http.Cookie{Name: tokenCookie, Value: h.token} req, _ := http.NewRequest("GET", h.ts.URL+"/", nil) req.AddCookie(plain) resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } page, _ := io.ReadAll(resp.Body) resp.Body.Close() if strings.Contains(string(page), ">friend<") { t.Error("a plain-text cookie was accepted as a session") } if c := findCookie(resp, tokenCookie); c == nil || c.MaxAge >= 0 { t.Error("the unusable cookie was not cleared, so the browser keeps sending it") } // Nor does it work anywhere the cookie is a credential. res := h.formUploadWith(t, plain, map[string]string{"vanity": "should-not-work"}, "f.txt", "x") defer res.Body.Close() if res.StatusCode != http.StatusForbidden { t.Errorf("upload with a plain-text cookie = %s, want 403", res.Status) } // A cookie sealed by a different server is just as dead. other, err := newSealer(filepath.Join(t.TempDir(), "session.key")) if err != nil { t.Fatal(err) } sealed, err := other.seal(h.token) if err != nil { t.Fatal(err) } if got := h.sessions.open(sealed); got != "" { t.Errorf("a cookie from another key opened to %q", got) } } // The key outlives the process: a restart must not log everyone out. func TestSessionKeyIsReusedAcrossRestarts(t *testing.T) { dir := t.TempDir() path := filepath.Join(dir, "session.key") first, err := newSealer(path) if err != nil { t.Fatal(err) } sealed, err := first.seal("a-token") if err != nil { t.Fatal(err) } second, err := newSealer(path) if err != nil { t.Fatal(err) } if got := second.open(sealed); got != "a-token" { t.Errorf("after a restart the cookie opened to %q, want the token back", got) } info, err := os.Stat(path) if err != nil { t.Fatal(err) } if perm := info.Mode().Perm(); perm != 0o600 { t.Errorf("session key mode = %o, want 600: it is credential material", perm) } // A key that is present but unusable must stop the server rather than be // replaced, which would silently log out every session. if err := os.WriteFile(path, []byte("not a key"), 0o600); err != nil { t.Fatal(err) } if _, err := newSealer(path); err == nil { t.Error("a corrupt session key was accepted") } } // Two seals of the same token must differ, or the cookie becomes a stable // fingerprint of which token a visitor holds. func TestSealingIsNotDeterministic(t *testing.T) { s, err := newSealer(filepath.Join(t.TempDir(), "session.key")) if err != nil { t.Fatal(err) } first, err := s.seal("a-token") if err != nil { t.Fatal(err) } second, err := s.seal("a-token") if err != nil { t.Fatal(err) } if first == second { t.Error("sealing the same token twice gave the same cookie") } for _, c := range []string{first, second} { if got := s.open(c); got != "a-token" { t.Errorf("cookie opened to %q, want the token", got) } } } // A session whose token has since been revoked must not wedge the page. func TestStaleCookieIsDropped(t *testing.T) { h := newHarness(t, nil) req, _ := http.NewRequest("GET", h.ts.URL+"/", nil) req.AddCookie(&http.Cookie{Name: tokenCookie, Value: "a-token-that-was-revoked"}) resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } defer resp.Body.Close() if resp.StatusCode != http.StatusOK { t.Fatalf("status = %s, want the page to still render", resp.Status) } if c := findCookie(resp, tokenCookie); c == nil || c.MaxAge >= 0 { t.Error("a stale cookie was not dropped") } page, _ := io.ReadAll(resp.Body) if !strings.Contains(string(page), "no longer valid") { t.Error("the page does not explain that the session ended") } if !strings.Contains(string(page), "anonymous") { t.Error("the page claims an identity it could not resolve") } } // The session is resolved server-side, so every page agrees about who you are // even though the cookie is unreadable by script. func TestIndexShowsWhoIsLoggedIn(t *testing.T) { h := newHarness(t, nil) req, _ := http.NewRequest("GET", h.ts.URL+"/", nil) req.AddCookie(h.session(t, h.token)) resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } defer resp.Body.Close() page, _ := io.ReadAll(resp.Body) if !strings.Contains(string(page), ">friend<") { t.Error("the page does not show who is logged in") } if strings.Contains(string(page), h.token) { t.Error("the page echoes the token back into the HTML") } } // The per-object delete token must still work when a cookie is also present. func TestCookieDoesNotShadowTheDeleteToken(t *testing.T) { h := newHarness(t, nil) // Uploaded anonymously, so the logged-in token owns nothing here. res := decode[uploadResult](t, h.upload(t, []byte("x"), nil)) form := strings.NewReader("token=" + res.DeleteToken) req, _ := http.NewRequest("POST", h.ts.URL+"/d/"+res.ID+"/delete", form) req.Header.Set("Content-Type", "application/x-www-form-urlencoded") req.Header.Set("Accept", "application/json") req.AddCookie(h.session(t, h.token)) resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } defer resp.Body.Close() if resp.StatusCode != http.StatusOK { t.Fatalf("status = %s, want 200: the cookie shadowed the delete token", resp.Status) } } func findCookie(resp *http.Response, name string) *http.Cookie { for _, c := range resp.Cookies() { if c.Name == name { return c } } return nil } // formUpload posts the multipart form the browser would, with fields ordered // ahead of the file part. func (h *harness) formUpload(t *testing.T, fields map[string]string, filename, content string) *http.Response { t.Helper() return h.formUploadWith(t, nil, fields, filename, content) } func (h *harness) formUploadWith(t *testing.T, cookie *http.Cookie, fields map[string]string, filename, content string) *http.Response { t.Helper() var body bytes.Buffer mw := multipart.NewWriter(&body) for k, v := range fields { mw.WriteField(k, v) } fw, err := mw.CreateFormFile("file", filename) if err != nil { t.Fatal(err) } fw.Write([]byte(content)) mw.Close() req, _ := http.NewRequest("POST", h.ts.URL+"/upload", &body) req.Header.Set("Content-Type", mw.FormDataContentType()) req.Header.Set("Accept", "application/json") if cookie != nil { req.AddCookie(cookie) } resp, err := h.ts.Client().Do(req) if err != nil { t.Fatal(err) } return resp } // --- favicon -------------------------------------------------------------- // No icon is committed, so the selection logic is exercised against stand-in // filesystems: a build that has one is a build nobody can write a test for. func TestFaviconSelection(t *testing.T) { for _, c := range []struct { name string files []string want string }{ {"nothing shipped", nil, ""}, {"a png", []string{"favicon.png"}, "favicon.png"}, {"an ico", []string{"favicon.ico"}, "favicon.ico"}, {"both, png wins", []string{"favicon.ico", "favicon.png"}, "favicon.png"}, {"something else entirely", []string{"logo.png"}, ""}, } { fsys := fstest.MapFS{} for _, f := range c.files { fsys[f] = &fstest.MapFile{Data: []byte("x")} } if got := faviconFor(fsys); got != c.want { t.Errorf("%s: faviconFor = %q, want %q", c.name, got, c.want) } } } // With no icon in the build, the markup must not promise one: a link to a // missing file costs every visitor a 404 on every page. func TestNoFaviconMeansNoLink(t *testing.T) { h := newHarness(t, nil) if h.favicon != "" { t.Skipf("this build embeds %q, so the empty case cannot be checked here", h.favicon) } resp := h.get(t, "/", "") page, _ := io.ReadAll(resp.Body) resp.Body.Close() if strings.Contains(string(page), `rel="icon"`) { t.Error("the page links an icon that this build does not carry") } resp = h.get(t, "/favicon.ico", "") resp.Body.Close() if resp.StatusCode != http.StatusNotFound { t.Errorf("GET /favicon.ico = %s, want 404 when no icon is embedded", resp.Status) } } // --- the footer ------------------------------------------------------------ // The footer names where the source lives, and an instance that would rather // not say so can drop it. A fork gets to point at its own. func TestSourceLinkIsOptional(t *testing.T) { shown := newHarness(t, nil) resp := shown.get(t, "/", "") page, _ := io.ReadAll(resp.Body) resp.Body.Close() if !strings.Contains(string(page), `